src: reset process.versions during pre-execution#53444
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 20, 2024
Merged
src: reset process.versions during pre-execution#53444nodejs-github-bot merged 1 commit intonodejs:mainfrom
process.versions during pre-execution#53444nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset
process.versionsduring pre-execution so that it reflects the versions at run-time rather than when the snapshot was taken.Fixes: #51007 (comment)
I'm not sure there's an easy way to test this currently in the CI -- it requires Node.js to be built against a dynamically linked library (e.g. zlib[1]) at one version and then run against a different, ABI-compatible version so that the snapshot has one version of the dependency recorded but Node.js is actually running with a different one.
cc @joyeecheung -- re. #51007 (comment) -- it seemed easier to reset the entire
process.versionsobject rather than checking each individual entry (and also meant I could extract and reuse the setting code).[1]: OpenSSL would be another, but there's a separate bug with obtaining the version of OpenSSL that I'll open another PR for.