Skip to content

build: harmonize Clang checks and update V8 warning cflags#52873

Closed
targos wants to merge 2 commits intomainfrom
clang-config
Closed

build: harmonize Clang checks and update V8 warning cflags#52873
targos wants to merge 2 commits intomainfrom
clang-config

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented May 7, 2024

  • Set the clang variable in config.gypi so it depends on compiler
    checks made by the configure script.
  • Replace gyp conditions with llvm_version and "0.0" with conditions
    that use the clang variable.
  • Always use clang==1 or clang==0 in gyp conditions

This will help for #52870

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@targos @nodejs-github-bot @anonrig @richardlau @VoltrexKeyva