Skip to content

src: use global SealHandleScope #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevnorris wants to merge 6 commits into from
Closed

src: use global SealHandleScope #3945

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8344161
build: fix --without-ssl compile time error
bnoordhuis Nov 14, 2015
ca97fb6
deps: upgrade npm to 2.14.9
othiym23 Nov 6, 2015
caa16b4
tls: prevent server from using dhe keys < 768
mhdawson Nov 17, 2015
3aa093e
deps: backport 1f8555 from v8's upstream
trevnorris Sep 23, 2015
c44a95d
src: use global SealHandleScope
trevnorris Sep 23, 2015
7d72435
node: fix leaking Context handle
trevnorris Nov 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: fix --without-ssl compile time error 
Fix the following build error by putting #if guards around the
variables:

    ../src/node.cc: In function 'void node::ParseArgs(int*,
    const char**, int*, const char***, int*, const char***)':
    ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared
    in this scope
           SSL2_ENABLE = true;
           ^
    ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared
    in this scope
           SSL3_ENABLE = true;

Fixes: nodejs/node-v0.x-archive#8645
PR-URL: #3825
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
@bnoordhuis @jasnell
bnoordhuis authored and jasnell committed Nov 15, 2015
commit 83441616a59de08ea90ce9d8cf926ad71a9d5c81
4 changes: 4 additions & 0 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3034,9 +3034,13 @@ static void ParseArgs(int* argc,
printf("%s\n", NODE_VERSION);
exit(0);
} else if (strcmp(arg, "--enable-ssl2") == 0) {
#if HAVE_OPENSSL
SSL2_ENABLE = true;
#endif
} else if (strcmp(arg, "--enable-ssl3") == 0) {
#if HAVE_OPENSSL
SSL3_ENABLE = true;
#endif
} else if (strcmp(arg, "--help") == 0 || strcmp(arg, "-h") == 0) {
PrintHelp();
exit(0);
Expand Down