Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is continuation of #35019, rebased on current master. I have taken it over from @voxik.
Additional changes
fipsModeconstant was replaced by (hopefully) internal binding toFIPS_selftest()OpenSSL function.The binding is called
testFipsCrypto()and it simply returns 1 or 0 based on the FIPS status reported by OpenSSL.The relevant tests were adjusted to rely on this in place of the original constant.
Open problems
There is still the issue of reporting errors in
InitCryptoOnce():The
UNREACHABLE()section is not so unreachable anymore 😉.Unfortunately, I was not able to figure out better way to report an error – anything similar to
return ThrowCryptoError(env, err)requires a reference to the environment, which AFAIK is not available in theInitCryptoOnce().Any pointers?
Fixes #34903; obsoletes/closes #35019.