Makefile: Add lint-python which uses flake8#21952
Merged
refack merged 1 commit intonodejs:masterfrom Oct 24, 2018
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a lint-python section to Makefile which pip installs flake8 and then executes:
Based on the experimentation done at https://travis-ci.com/nodejs/node/builds/79706150 - #21942
These tests currently exclude several directories and files:
Hopefully this list can be reduced in future PRs with code modifications or the use of # noqa
E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
namenamein__all__namereferenced before assignmentChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes