async_hooks: skip sanity checks when disabled#15454
Closed
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
AndreasMadsen:async-hooks-opt-in-checks
Closed
async_hooks: skip sanity checks when disabled#15454AndreasMadsen wants to merge 1 commit intonodejs:masterfrom AndreasMadsen:async-hooks-opt-in-checks
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
AndreasMadsen:async-hooks-opt-in-checks
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks
While async_hooks is experimental we should skip the sanity checks when async_hooks is disabled. If someone would like a flag as well, we could add another
async_hooks_fieldthat is> 0when either the flag is used or the hooks are enabled. Should be trivial.This makes the sanity checks stricter when
async_hooksis enabled, so be sure to run CITGM before merging this. However, sinceasync_hooksis rarely enabled there shouldn't be any issues.CI: https://ci.nodejs.org/job/node-test-pull-request/10120/
Ref: #14387
Ref: #14722
Ref: #14717
Ref: #15448