build: better support for python3 systems#14737
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
build: better support for python3 systems#14737bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve support for systems where
pythonis actuallypython3.Not all systems have a
python2binary, so simply updating the shebangwon't work.
What we can do is apply some cleverness: start life as a shell script,
locate the python binary, then re-execute the script but this time as
python code.
Special care is taken to ensure that spaces in arguments are passed on
verbatim.
This would need to be applied to other python scripts as well but I figured
I'd start with a single script in case everyone hates the approach.
CI: https://ci.nodejs.org/job/node-test-pull-request/9594/