fs: refactor to remove redundant validation

RaisinTen · jasnell · commit ae5e95f9c587 · 2021-01-22T19:51:57.000-08:00
The function makeCallback already calls validateCallback, so the call inside copyFile can be removed. PR-URL: #36984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -2036,8 +2036,6 @@ function copyFile(src, dest, mode, callback) {
   if (typeof mode === 'function') {
     callback = mode;
     mode = 0;
-  } else {
-    validateCallback(callback);
   }
 
   src = getValidatedPath(src, 'src');

Original file line number	Diff line number	Diff line change
`@@ -2036,8 +2036,6 @@ function copyFile(src, dest, mode, callback) {`
`2036`	`2036`	`if (typeof mode === 'function') {`
`2037`	`2037`	`callback = mode;`
`2038`	`2038`	`mode = 0;`
`2039`		`- } else {`
`2040`		`- validateCallback(callback);`
`2041`	`2039`	`}`
`2042`	`2040`
`2043`	`2041`	`src = getValidatedPath(src, 'src');`