module: fix coverage of mocked CJS modules imported from ESM

marcopiraccini · web-flow · commit 6f7b948a492e · 2026-03-17T16:02:55.000Z
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com> PR-URL: #62133 Fixes: #61709 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
diff --git a/lib/internal/modules/esm/translators.js b/lib/internal/modules/esm/translators.js
@@ -108,7 +108,9 @@ const kShouldNotSkipModuleHooks = { __proto__: null, shouldSkipModuleHooks: fals
  * @param {boolean} isMain - Whether the module is the entrypoint
  */
 function loadCJSModule(module, source, url, filename, isMain) {
-  const compileResult = compileFunctionForCJSLoader(source, filename, false /* is_sea_main */, false);
+  // Use the full URL as the V8 resource name so that any search params
+  // (e.g. ?node-test-mock) are preserved in coverage reports.
+  const compileResult = compileFunctionForCJSLoader(source, url, false /* is_sea_main */, false);
 
   const { function: compiledWrapper, sourceMapURL, sourceURL } = compileResult;
   // Cache the source map for the cjs module if present.
diff --git a/test/fixtures/test-runner/coverage-with-mock/dependency.cjs b/test/fixtures/test-runner/coverage-with-mock/dependency.cjs
@@ -0,0 +1,9 @@
+throw new Error('This should never be called');
+
+exports.dependency = function dependency() {
+  return 'foo';
+}
+
+exports.unused = function unused() {
+  return 'bar';
+}
diff --git a/test/fixtures/test-runner/coverage-with-mock/subject.mjs b/test/fixtures/test-runner/coverage-with-mock/subject.mjs
@@ -0,0 +1,5 @@
+import { dependency } from './dependency.cjs';
+
+export function subject() {
+  return dependency();
+}
diff --git a/test/fixtures/test-runner/output/coverage-with-mock-cjs.mjs b/test/fixtures/test-runner/output/coverage-with-mock-cjs.mjs
@@ -0,0 +1,11 @@
+import { mock, test } from 'node:test';
+
+const dependency = mock.fn(() => 'mock-return-value');
+mock.module('../coverage-with-mock/dependency.cjs', { namedExports: { dependency } });
+
+const { subject } = await import('../coverage-with-mock/subject.mjs');
+
+test('subject calls dependency', (t) => {
+  t.assert.strictEqual(subject(), 'mock-return-value');
+  t.assert.strictEqual(dependency.mock.callCount(), 1);
+});
diff --git a/test/fixtures/test-runner/output/coverage-with-mock-cjs.snapshot b/test/fixtures/test-runner/output/coverage-with-mock-cjs.snapshot
@@ -0,0 +1,31 @@
+TAP version 13
+# Subtest: subject calls dependency
+ok 1 - subject calls dependency
+  ---
+  duration_ms: *
+  type: 'test'
+  ...
+1..1
+# tests 1
+# suites 0
+# pass 1
+# fail 0
+# cancelled 0
+# skipped 0
+# todo 0
+# duration_ms *
+# start of coverage report
+# -------------------------------------------------------------------------------
+# file                           | line % | branch % | funcs % | uncovered lines
+# -------------------------------------------------------------------------------
+# test                           |        |          |         |
+#  fixtures                      |        |          |         |
+#   test-runner                  |        |          |         |
+#    coverage-with-mock          |        |          |         |
+#     subject.mjs                | 100.00 |   100.00 |  100.00 |
+#    output                      |        |          |         |
+#     coverage-with-mock-cjs.mjs | 100.00 |   100.00 |  100.00 |
+# -------------------------------------------------------------------------------
+# all files                      | 100.00 |   100.00 |  100.00 |
+# -------------------------------------------------------------------------------
+# end of coverage report
diff --git a/test/test-runner/test-output-coverage-with-mock-cjs.mjs b/test/test-runner/test-output-coverage-with-mock-cjs.mjs
@@ -0,0 +1,22 @@
+import * as common from '../common/index.mjs';
+import * as fixtures from '../common/fixtures.mjs';
+import { spawnAndAssert, defaultTransform, ensureCwdIsProjectRoot } from '../common/assertSnapshot.js';
+
+if (!process.features.inspector) {
+  common.skip('inspector support required');
+}
+
+ensureCwdIsProjectRoot();
+await spawnAndAssert(
+  fixtures.path('test-runner/output/coverage-with-mock-cjs.mjs'),
+  defaultTransform,
+  {
+    flags: [
+      '--disable-warning=ExperimentalWarning',
+      '--test-reporter=tap',
+      '--experimental-test-module-mocks',
+      '--experimental-test-coverage',
+      '--test-coverage-exclude=!test/**',
+    ],
+  },
+);
