Closed
Conversation
Node.js v6.x is EOL. Keeping it around makes it more dificult to support new versions, so dropping support seems reasonable. This is semver-major.
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 81.79% 79.85% -1.94%
==========================================
Files 33 33
Lines 4229 4229
==========================================
- Hits 3459 3377 -82
- Misses 770 852 +82
Continue to review full report at Codecov.
|
cjihrig
approved these changes
Sep 18, 2019
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
+1 to dropping support for EOL release lines.
Contributor
Author
|
cc @nodejs/llnode @nodejs/diagnostics @nodejs/post-mortem for visibility |
richardlau
approved these changes
Sep 18, 2019
joyeecheung
approved these changes
Sep 20, 2019
mmarchini
added a commit
that referenced
this pull request
Sep 20, 2019
Node.js v6.x is EOL. Keeping it around makes it more dificult to support new versions, so dropping support seems reasonable. This is semver-major. PR-URL: #292 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Contributor
Author
|
Landed in e1a74b0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 81.79% 79.85% -1.94%
==========================================
Files 33 33
Lines 4229 4229
==========================================
- Hits 3459 3377 -82
- Misses 770 852 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js v6.x is EOL. Keeping it around makes it more dificult to support
new versions, so dropping support seems reasonable. This is
semver-major.