Skip to content

Change baseimage for node:slim to stretch release#822

Closed
mkumatag wants to merge 1 commit intonodejs:masterfrom
mkumatag:update_baseimage
Closed

Change baseimage for node:slim to stretch release#822
mkumatag wants to merge 1 commit intonodejs:masterfrom
mkumatag:update_baseimage

Conversation

@mkumatag
Copy link
Copy Markdown

Fixes: #821

@mkumatag
Copy link
Copy Markdown
Author

/cc @PeterDaveHello

PeterDaveHello

This comment was marked as off-topic.

@PeterDaveHello
Copy link
Copy Markdown
Member

/cc @nodejs/docker

PeterDaveHello

This comment was marked as off-topic.

@mkumatag
Copy link
Copy Markdown
Author

We don't directly update the Dockerfile, instead, we need to update the templates at the root of the repository.

I suggest to make decision at the issue, and after that, send the pull request.

How it works? I see those 2 packages are missing, so do you want me to create a separate template called Dockerfile-slim-stretch.template or something?

@PeterDaveHello
Copy link
Copy Markdown
Member

I suppose we should discuss before making changes, let's move back to the issue.

@LaurentGoderre
Copy link
Copy Markdown
Member

I think the changes have to be made to the following file:

https://github.com/nodejs/docker-node/blob/master/Dockerfile-slim.template

Then the update will be picked up on next release.

@mkumatag
Copy link
Copy Markdown
Author

@LaurentGoderre can you drop your suggestion in #821 ?

@chorrell
Copy link
Copy Markdown
Contributor

Would it be better to just have a separate stretch-slim variant rather than modifying the current slim variant? I'm thinking we should treat it like we do with the default variant.

@mkumatag
Copy link
Copy Markdown
Author

mkumatag commented Aug 3, 2018

@PeterDaveHello @LaurentGoderre I just made suggested changes, PTAL and let me know if anything else is required.?

@LaurentGoderre
Copy link
Copy Markdown
Member

@chorrell do you mean we'd have a stretch-slim and a jessy-slim?

@chorrell
Copy link
Copy Markdown
Contributor

Yeah

@kbirger
Copy link
Copy Markdown

kbirger commented Sep 4, 2018

@PeterDaveHello are your requests satisfied? Seems like this could be merged now.

@LaurentGoderre
Copy link
Copy Markdown
Member

I opened #850 as an alternative for a smoother transition.

@LaurentGoderre
Copy link
Copy Markdown
Member

Closing as this was addressed via #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants