Skip to content

Add language label only if class attribute exists#85

Closed
hangindev wants to merge 1 commit intonnja:masterfrom
hangindev:master
Closed

Add language label only if class attribute exists#85
hangindev wants to merge 1 commit intonnja:masterfrom
hangindev:master

Conversation

@hangindev
Copy link
Copy Markdown
Contributor

@hangindev hangindev commented Oct 1, 2020

The app breaks if any of the $('pre code') tags doesn't have a class attribute. For example https://www.learnpython.dev/02-introduction-to-python/060-functions/30-function-arguments/

I change the code to be more forgiving so that it will not break which fixes #80.

@nnja nnja mentioned this pull request Oct 12, 2020
@nnja nnja closed this in #97 Oct 12, 2020
@nnja
Copy link
Copy Markdown
Owner

nnja commented Oct 12, 2020

Good eye! Thank you so much for your contribution.

@hangindev
Copy link
Copy Markdown
Contributor Author

Thank you for your courses! Looking forward to "A Practical Guide to Python".

P.S. sorry you had to deal with all those spammy PRs.

@nnja
Copy link
Copy Markdown
Owner

nnja commented Oct 13, 2020

Thank you for your courses! Looking forward to "A Practical Guide to Python".

P.S. sorry you had to deal with all those spammy PRs.

I only had a handful of PRs to close -- definitely not as bad as other projects!

I hope to see you at a Practical Guide to Python, but wanted to give you a heads up that the content will be quite similar to this two day workshop. Instead of focusing on folks who are absolute beginners to programming, Practical Python will condense two days of material into one, focusing on developers who know another language and are looking to get productive with Python as quickly as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single lesson not showing Checkmark

2 participants