Skip to content

Conversation

@Akira-Al
Copy link

Fix for #3158

modified libpcap/Makefile.in and change VERSION to VERSION.txt

@ajbr0wn
Copy link

ajbr0wn commented Aug 3, 2025

Just a thought, would it be simpler to rename VERSION.txt to VERSION instead of changing the references? I think that would require fewer code changes and it matches upstream libpcap convention.

@Akira-Al
Copy link
Author

Akira-Al commented Aug 4, 2025

That would work on most Linux systems and match the upstream libpcap convention, but it wouldn’t help on macOS because the filesystem is case-insensitive. This causes issues like the one described in Issue #2747.

@Akira-Al
Copy link
Author

Akira-Al commented Aug 4, 2025

For fewer code changes, it could be possible to include

mv VERSION VERSION.txt
sed -i '' 's/VERSION/VERSION.txt/g' ./Makefile.in

in libpcap/configure or something and make it automated on specific systems, but I haven't thought it through properly.
Which would make a git diff every time I guess...

@akahunahi
Copy link

akahunahi commented Sep 23, 2025

That would work on most Linux systems and match the upstream libpcap convention, but it wouldn’t help on macOS because the filesystem is case-insensitive. This causes issues like the one described in Issue #2747.

Unless it is built with a MacOS Case Sensitive file system. The OS supports both.

Updated comment here:
#3158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants