Merge pull request #5566 from nextcloud/fix/linkbubble_scroll_handler

mejo- · web-flow · commit 1662a1a9ea2e · 2024-03-25T14:53:02.000+01:00
fix(LinkBubble): Limit hide on scroll to div elements
diff --git a/src/plugins/LinkBubblePluginView.js b/src/plugins/LinkBubblePluginView.js
@@ -25,10 +25,16 @@ class LinkBubblePluginView {
 	}
 
 	dragOrScrollHandler = (event) => {
+		// Only hide when scrolling on `<div>` (not .e.g. on `<input>`)
+		if (event.target.nodeName !== 'DIV') {
+			return
+		}
+
 		// Cypress fires unexpected scroll events, which breaks testing the link bubble
 		if (window.Cypress) {
 			return
 		}
+
 		this.hide()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,16 @@ class LinkBubblePluginView {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`dragOrScrollHandler = (event) => {`
	`28`	+ // Only hide when scrolling on `<div>` (not .e.g. on `<input>`)
	`29`	`+ if (event.target.nodeName !== 'DIV') {`
	`30`	`+ return`
	`31`	`+ }`
	`32`	`+`
`28`	`33`	`// Cypress fires unexpected scroll events, which breaks testing the link bubble`
`29`	`34`	`if (window.Cypress) {`
`30`	`35`	`return`
`31`	`36`	`}`
	`37`	`+`
`32`	`38`	`this.hide()`
`33`	`39`	`}`
`34`	`40`