Remove .inf extension from file filter in build workflow#21941
Merged
ilyam8 merged 1 commit intonetdata:masterfrom Mar 12, 2026
Merged
Remove .inf extension from file filter in build workflow#21941ilyam8 merged 1 commit intonetdata:masterfrom
.inf extension from file filter in build workflow#21941ilyam8 merged 1 commit intonetdata:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Windows code-signing step in the build workflow to avoid attempting to sign .inf files, which are not valid signing targets and can cause installer signing failures.
Changes:
- Remove
inffrom thefiles-folder-filterused byazure/artifact-signing-actionwhen signing Windows build outputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyam8
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Exclude
.inffiles from Windows code signing by removinginffrom the workflow’sfiles-folder-filter. This prevents invalid signing attempts and reduces failures in the installer signing step.Written for commit ff9ec6d. Summary will update on new commits.