Skip to content

Remove .inf extension from file filter in build workflow#21941

Merged
ilyam8 merged 1 commit intonetdata:masterfrom
stelfrag:fix_win_installer_sign
Mar 12, 2026
Merged

Remove .inf extension from file filter in build workflow#21941
ilyam8 merged 1 commit intonetdata:masterfrom
stelfrag:fix_win_installer_sign

Conversation

@stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Mar 12, 2026

Summary
  • Exclude inf files from signature

Summary by cubic

Exclude .inf files from Windows code signing by removing inf from the workflow’s files-folder-filter. This prevents invalid signing attempts and reduces failures in the installer signing step.

Written for commit ff9ec6d. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@stelfrag stelfrag marked this pull request as ready for review March 12, 2026 07:27
@stelfrag stelfrag requested a review from a team as a code owner March 12, 2026 07:27
Copilot AI review requested due to automatic review settings March 12, 2026 07:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows code-signing step in the build workflow to avoid attempting to sign .inf files, which are not valid signing targets and can cause installer signing failures.

Changes:

  • Remove inf from the files-folder-filter used by azure/artifact-signing-action when signing Windows build outputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stelfrag stelfrag requested a review from thiagoftsm March 12, 2026 12:14
@ilyam8 ilyam8 merged commit 264150a into netdata:master Mar 12, 2026
150 checks passed
@stelfrag stelfrag deleted the fix_win_installer_sign branch March 12, 2026 12:48
stelfrag added a commit to stelfrag/netdata that referenced this pull request Mar 17, 2026
@stelfrag stelfrag mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants