You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
AsyncHooksModule which uses async_hooks module capabilities (share async state, for example, between HTTP requests). Blocked due to memory leaks - async_hooks is still in experimental stage.
Instead of using async_hooks directly, we should explore using AsyncLocalStorage to provide this functionality. It was released in Node.js 14 and is part of the experimental async_hooks module.
Instead of using async_hooks directly, we should explore using AsyncLocalStorage to provide this functionality. It was released in Node.js 14 and is part of the experimental async_hooks module.
it has even been back ported to Node.js 12 ( the latest EOL release :-) )
I was also looking for this functionality, so I spent some time researching and testing and the result is this package: https://github.com/Papooch/nestjs-cls
It would be great if Nest provided some 'request hooks' so we could wrap the execution context of the whole request somehow instead of relying on a middleware or an 'enhancer' (though I don't know if that's even possible)
Any updates? This issue is basically 3 years old, and it seems like the node AsyncLocalStorage API has matured quite a bit in that time. I think it would make a huge impact on NestJS- specifically as a mechanism to pass req/ctx while avoiding the performance penalty of request scoped providers.
specifically as a mechanism to pass req/ctx while avoiding the performance penalty of request scoped providers.
I wouldn't be so sure that using AsyncLocalStorage atm would be better (performance-wise) than properly designed request-scoped providers.
Any updates? This issue is basically 3 years old
According to the official Node.js docs, async_hooks are still experimentalhttps://nodejs.org/api/async_hooks.html and this PR won't get merged till that changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kamilmysliwiec
changed the title
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
AsyncHooksModulewhich usesasync_hooksmodule capabilities (share async state, for example, between HTTP requests). Blocked due to memory leaks -async_hooksis still in experimental stage.Does this PR introduce a breaking change?
Other information