Improve parsing macros: convert to functions and merge MoreArgs variants #4752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing macros
MoreArgs(),MoreArgsF(), andSKIPWS()were hard to understand, debug, and test. This PR converts them to proper functions and unifies theMoreArgsvariants.Changes
New functions replacing macros
skip_ws(char **ptr)inmutt/string.c— skips whitespace, used bySKIPWSmacromore_args(struct Buffer *buf, TokenFlags flags)inparse/extract.c— unified function for argument checkingBackward-compatible macro aliases
SKIPWS(ch)→skip_ws(&(ch))MoreArgs(buf)→more_args(buf, TOKEN_SPACE)MoreArgsF(buf, flags)→more_args(buf, flags)New tests
test/parse/more_args.c— tests forMoreArgs()andMoreArgsF()behaviortest/parse/skipws.c— tests forSKIPWS()behaviorExample usage
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.