Replace AliasList with AliasArray using ARRAY_HEAD #4701
+100
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@copilot try again |
Author
Done! I've successfully replaced AliasList (TAILQ_HEAD) with AliasArray (ARRAY_HEAD) in commit 220bab2. The changes include:
|
Copilot
AI
changed the title
[WIP] Replace AliasList with AliasArray using ARRAY_HEAD
Replace AliasList with AliasArray using ARRAY_HEAD
Nov 22, 2025
Member
|
@copilot rename AliasArray variables from |
Author
flatcap
force-pushed
the
copilot/replace-aliaslist-with-aliasarray
branch
from
2ef6693 to
c0bef7c
Compare
flatcap
force-pushed
the
copilot/replace-aliaslist-with-aliasarray
branch
from
c0bef7c to
c5981e3
Compare
flatcap
force-pushed
the
copilot/replace-aliaslist-with-aliasarray
branch
from
c5981e3 to
3958b85
Compare
- Remove TAILQ_ENTRY from struct Alias - Define AliasArray using ARRAY_HEAD(AliasArray, struct Alias *) - Update global Aliases variable to use AliasArray - Replace all TAILQ operations with ARRAY operations: - TAILQ_FOREACH → ARRAY_FOREACH - TAILQ_INSERT_TAIL → ARRAY_ADD - TAILQ_REMOVE → ARRAY_REMOVE - TAILQ_HEAD_INITIALIZER → ARRAY_HEAD_INITIALIZER - TAILQ_EMPTY → ARRAY_EMPTY - Update aliaslist_clear() to work with AliasArray - Update function signatures in functions.h and gui.h - Update all usage in alias.c, commands.c, dlg_alias.c, dlg_query.c, and functions.c Assisted-by: GitHub Copilot
flatcap
force-pushed
the
copilot/replace-aliaslist-with-aliasarray
branch
from
3958b85 to
99137c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
AliasListdata structure (based onTAILQ_HEADlinked list) withAliasArray(based onARRAY_HEADdynamic array) throughout the alias module. This modernizes the alias storage mechanism to use array-based data structures instead of linked lists.Key changes:
TAILQ_ENTRY(Alias)fromstruct AliasAliasArrayusingARRAY_HEAD(AliasArray, struct Alias *)Aliasesvariable to useAliasArrayTAILQ_FOREACH→ARRAY_FOREACHTAILQ_INSERT_TAIL→ARRAY_ADDTAILQ_REMOVE→ARRAY_REMOVETAILQ_HEAD_INITIALIZER→ARRAY_HEAD_INITIALIZERTAILQ_EMPTY→ARRAY_EMPTYaliaslist_clear()to work withAliasArrayfunctions.handgui.halias.c,commands.c,dlg_alias.c,dlg_query.c, andfunctions.caltoaafor consistency and clarityN/A - Internal data structure change with no UI impact
Does this PR meet the acceptance criteria?
What are the relevant issue numbers?
N/A
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.