Revert "support tvos (#1061)"#1090
Merged
marklawlor merged 1 commit intonativewind:mainfrom Sep 19, 2024
douglowder:revert-tv-changes
Merged
Revert "support tvos (#1061)"#1090marklawlor merged 1 commit intonativewind:mainfrom douglowder:revert-tv-changes
marklawlor merged 1 commit intonativewind:mainfrom
douglowder:revert-tv-changes
Conversation
This reverts commit 32d1085.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would probably be a better separation of concerns, and more maintainable and configurable, to revert this change. Instead, I propose to modify RNTV to send the expected
onPressInandonPressOutmethods when controls are selected.For example, the TV repo could add a new prop to
PressableandTouchableto configure the amount of timeactiveis true when the TV remote selects a control.Example of what the RNTV change might look like: https://github.com/douglowder/NativeWindTV/blob/doug/nativewind-v4/patches/react-native%2B0.74.5-0.patch