feat: add optional secret handling for server status reporting#215
Open
froz42 wants to merge 2 commits intomsgbyte:masterfrom
Open
feat: add optional secret handling for server status reporting#215froz42 wants to merge 2 commits intomsgbyte:masterfrom
froz42 wants to merge 2 commits intomsgbyte:masterfrom
Conversation
froz42
force-pushed
the
master
branch
2 times, most recently
from
9652638 to
693b6ea
Compare
Contributor
|
i think its looks verrrrrrrrrry cool but can you support workspace feature rather than only use env? or i can finish it later, but maybe rebase and resolve conflict first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anyone can spoof server status reporting without a proper secret. This merge request is incomplete for the UI and install script but fix this.
if someone make the implementation of the script.sh it should not leak the credential or at least be protected by a token in the uri