Services' renaming: base.Base to base.Service

copitux · copitux · commit c99a6c5be7f4 · 2012-02-17T07:32:19.000+01:00
diff --git a/pygithub3/core/client.py b/pygithub3/core/client.py
@@ -99,7 +99,7 @@ def patch(self, request, **kwargs):
     def put(self, request, **kwargs):
         response = self.request('put', request, **kwargs)
         # assert response.status_code != '204'
-        # I don't do an assert. See `services.base.Base._put` comment
+        # I don't do an assert. See `services.base.Service._put` comment
         return response
 
     def delete(self, request, **kwargs):
diff --git a/pygithub3/exceptions.py b/pygithub3/exceptions.py
@@ -37,6 +37,6 @@ class UnprocessableEntity(Exception):
 class NotFound(Exception):
     """ Raised when server response is 404
 
-    Catched with a pygithub3-exception to `services.base.Base._bool` method
+    Catched with a pygithub3-exception to `services.base.Service._bool` method
     """
     pass
diff --git a/pygithub3/services/base.py b/pygithub3/services/base.py
@@ -7,7 +7,7 @@
 from pygithub3.core.errors import NotFound
 
 
-class Base(object):
+class Service(object):
 
     def __init__(self, **config):
         self._client = Client(**config)
diff --git a/pygithub3/services/repos.py b/pygithub3/services/repos.py
@@ -1,10 +1,10 @@
 #!/usr/bin/env python
 # -*- encoding: utf-8 -*-
 
-from .base import Base
+from .base import Service
 
 
-class Collaborator(Base):
+class Collaborator(Service):
 
     def list(self, user=None, repo=None):
         request = self.make_request('repos.collaborators.list',
@@ -34,7 +34,7 @@ def delete(self, collaborator, user=None, repo=None):
         self._delete(request)
 
 
-class Repo(Base):
+class Repo(Service):
 
     def __init__(self, **config):
         self.collaborators = Collaborator(**config)
diff --git a/pygithub3/services/users.py b/pygithub3/services/users.py
@@ -1,10 +1,10 @@
 #!/usr/bin/env python
 # -*- encoding: utf-8 -*-
 
-from .base import Base
+from .base import Service
 
 
-class Keys(Base):
+class Keys(Service):
 
     def list(self):
         request = self.make_request('users.keys.list')
@@ -31,7 +31,7 @@ def delete(self, key_id):
         self._delete(request)
 
 
-class Followers(Base):
+class Followers(Service):
 
     def list(self, user=None):
         request = self.make_request('users.followers.list',
@@ -59,7 +59,7 @@ def unfollow(self, user):
         self._delete(request)
 
 
-class Emails(Base):
+class Emails(Service):
 
     def list(self):
         request = self.make_request('users.emails.list')
@@ -74,7 +74,7 @@ def delete(self, *emails):
         self._delete(request)
 
 
-class User(Base):
+class User(Service):
 
     def __init__(self, **kwargs):
         self.keys = Keys(**kwargs)
diff --git a/pygithub3/tests/services/test_core.py b/pygithub3/tests/services/test_core.py
@@ -6,7 +6,7 @@
 
 import requests
 
-from pygithub3.services.base import Base
+from pygithub3.services.base import Service
 from pygithub3.core.result import Result
 from pygithub3.tests.utils.base import DummyRequest, mock_response
 from .utils import _
@@ -16,7 +16,7 @@
 class TestServiceCalls(TestCase):
 
     def setUp(self):
-        self.s = Base()
+        self.s = Service()
         self.r = DummyRequest()
         self.args = dict(arg1='arg1', arg2='arg2')
 
