Skip to content

Add FXIOS-14517 [Default browser] Improve utility #31414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adudenamedruby wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add FXIOS-14517 [Default browser] Improve utility #31414

adudenamedruby wants to merge 3 commits into from
+405 −46

Conversation

@adudenamedruby
Copy link
Contributor

@adudenamedruby adudenamedruby commented Dec 19, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

The details of what this PR does can be found thoroughly documented at the top of the DefaultBrowserUtility.swift file.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@adudenamedruby adudenamedruby force-pushed the rgb/dizzy-gallant-mushroom branch 2 times, most recently from e2019bc to 600d967 Compare December 19, 2025 18:31
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 19, 2025 •
edited
Loading

Messages
📖 Project coverage: 38.55%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.11

File Coverage
DefaultBrowserUtility.swift 94.06% ✅

Generated by 🚫 Danger Swift against d401e65

@adudenamedruby adudenamedruby force-pushed the rgb/dizzy-gallant-mushroom branch from 600d967 to fc88c2b Compare December 19, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adudenamedruby @mobiletest-ci-bot