fix(test-config): some layout and state issues (@byseif21)#7500
Open
byseif21 wants to merge 4 commits intomonkeytypegame:masterfrom
Open
fix(test-config): some layout and state issues (@byseif21)#7500byseif21 wants to merge 4 commits intomonkeytypegame:masterfrom
byseif21 wants to merge 4 commits intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes UI sizing + active-state inconsistencies in the test config bar when switching modes (esp. quote mode), including after viewport changes (DevTools) and when quote-length active classes get cleared.
Changes:
- Update mode-switch logic to call
updateActiveExtraButtonswith"quoteLength"(instead of"quote") when entering quote mode. - Remove an unconditional
quoteLengthactive-state update frominstantUpdate(so quote-length buttons aren’t force-touched when not in quote mode). - Clear the submenu’s inline
widthafter the transition animation to prevent stale fixed widths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix some widths issue for the test bar:
ways to reproduce
case 1
1- being logged in
2- switch to quote mode
3- log out
4- observe extra spacing before
allbuttoncase 2
1- switch between modes s (e.g., time → quote)
2- open DevTools "to change size"
3- switch modes again and be lastly in quote mode selection
3- close DevTools
4- the bar incorrectly sized
case 3
this have many inconstant way to reproduce but that will give what happens shortly
1- stay in a mode other than quote
2- open the console and run
qsa("#testConfig .quoteLength .textButton").removeClass("active")3- switch to quote mode
4- no buttons get rehighlighted as it should