DRIVERS-3181 fix timeouts in CSE custom endpoint test#1791
Merged
kevinAlbs merged 3 commits intomongodb:masterfrom Apr 29, 2025
Merged
DRIVERS-3181 fix timeouts in CSE custom endpoint test#1791kevinAlbs merged 3 commits intomongodb:masterfrom
kevinAlbs merged 3 commits intomongodb:masterfrom
Conversation
Intended to fix observed timeout connecting to AWS with an incorrect port. Connecting to `localhost:12345` is intended to fail immediately.
Intended to fix observed timeouts. `.invalid` is expected to fail to resolve immediately.
Not necessary to change since the URIs are not expected to be used. An error is expected earlier when connecting to the oauth endpoint. But the URIs are updated for consistency.
kevinAlbs
changed the title
kevinAlbs
requested review from
baileympearson,
katcharov and
rozza
and removed request for
a team and
katcharov
rozza
approved these changes
Apr 29, 2025
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
LGTM!
Tested here: mongodb/mongo-java-driver#1694
Contributor
|
Tests pass in Node as well: https://spruce.mongodb.com/version/6810dc1f0896a00007d55f46/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC (CI failures are unrelated) |
baileympearson
approved these changes
Apr 29, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Client-Side Encryption prose test
7. Custom Endpoint Testto fix recently seen timeout failures:localhostinstead of AWS..invalidinstead of.localfor test URIs intended to be invalid.Tested in C driver: mongodb/mongo-c-driver#2001
Background & Motivation
Drivers have seen recent test failures due to timeout. Node indicates failure in Client-Side Encryption prose test:
7. Custom Endpoint Testcase 4. Drivers are expected to connect to a KMS using the endpoint string from mongocrypt_kms_ctx_endpoint, so this test seemed meaningful to ensure drivers are handling a custom port. To avoid the timeout to AWS, the test is updated to use the "kmip" provider (expected succeed withlocalhost:5698) withlocalhost:12345.Java logs before a timeout:
doesnotexist.localis replaced withdoesnotexist.invalid. Quoting RFC 2606:Tests were run in the C driver. Though tests were not previously failing, logs indicate the test was very slow. On a prior commit:
With this PR:
Related: drivers do not use a consistent timeout for KMS requests (see DRIVERS-1049). I expect this is why C did not fail, and other drivers did.
Please complete the following before merging:
[ ] Update changelog.[ ] Test these changes against all server versions and topologies (including standalone, replica set, sharded(N/A. Only changing KMS endpoint).clusters, and serverless).