fix libgit2#25 Git\Tree::getEntryByName should return correct size of oid.

chobie · chobie · commit d2228fe2a7c8 · 2012-04-26T06:48:59.000+09:00
diff --git a/php_git2.h b/php_git2.h
@@ -257,7 +257,7 @@ static inline php_git2_create_signature_from_commit(zval **object, git_commit *c
 static inline void create_tree_entry_from_entry(zval **object, git_tree_entry *entry, git_repository *repository)
 {
 	TSRMLS_FETCH();
-	char buf[GIT_OID_HEXSZ] = {0};
+	char buf[GIT_OID_HEXSZ+1] = {0};
 	const git_oid *oid;
 	php_git2_tree_entry *m_entry;
 
@@ -267,7 +267,7 @@ static inline void create_tree_entry_from_entry(zval **object, git_tree_entry *e
 
 	m_entry->entry = entry;
 	oid = git_tree_entry_id(entry);
-	git_oid_tostr(buf,GIT_OID_HEXSZ,oid);
+	git_oid_tostr(buf,GIT_OID_HEXSZ+1,oid);
 
 	add_property_string(*object, "name", (char *)git_tree_entry_name(entry), 1);
 	add_property_string(*object, "oid", buf, 1);
diff --git a/tests/003-02-tree_iterate.phpt b/tests/003-02-tree_iterate.phpt
@@ -14,5 +14,5 @@ foreach ($tree as $entry) {
 }
 --EXPECT--
 README
-557db03de997c86a4a028e1ebd3a1ceb225be23
+557db03de997c86a4a028e1ebd3a1ceb225be238
 33188
diff --git a/tests/003-04-tree_get_entry_by_name.phpt b/tests/003-04-tree_get_entry_by_name.phpt
@@ -14,7 +14,7 @@ object(Git2\TreeEntry)#5 (3) {
   ["name"]=>
   string(6) "README"
   ["oid"]=>
-  string(39) "557db03de997c86a4a028e1ebd3a1ceb225be23"
+  string(40) "557db03de997c86a4a028e1ebd3a1ceb225be238"
   ["attributes"]=>
   int(33188)
 }
