Fix inconsistent autoconfig encryption settings #3843
+84
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscover XML Definitely better than hard-coding wrong values without even documenting it.
ntninja
changed the title
ntninja
changed the title
ntninja
force-pushed
the
fix-consistent-autoconfig-encryption
branch
from
357fd6b to
53ca0ef
Compare
ntninja
force-pushed
the
fix-consistent-autoconfig-encryption
branch
from
53ca0ef to
96ed44f
Compare
Useful for multi-domain deployments, allows `"HOSTNAME"` to be set to something like `"mail.%EMAILDOMAIN%"` to generate the requesting e-mail domain prefixed with “mail.”.
…files
Also adds the “{Incoming,Outgoing}MailServerAuthentication” as the docs state
it to be “required”.
ntninja
force-pushed
the
fix-consistent-autoconfig-encryption
branch
from
96ed44f to
afa72ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3843 +/- ##
==========================================
- Coverage 83.67% 83.67% -0.01%
==========================================
Files 314 314
Lines 15422 15432 +10
Branches 2040 2043 +3
==========================================
+ Hits 12904 12912 +8
- Misses 1826 1827 +1
- Partials 692 693 +1 🚀 New features to boost your workflow:
|
ntninja
force-pushed
the
fix-consistent-autoconfig-encryption
branch
from
afa72ee to
592168e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
New Microsoft AutoDiscover and Apple Mail MDM support used hard-coded transport encryption settings (immediate TLS IMAP and, inconsistently, StartTLS SMTP for Microsoft and immediate TLS for Apple). In addition, there was no documentation on the meaning of these values.
Current behavior before PR:
Works if you’re lucky that your settings match.
Desired behavior after PR is merged:
Can be fixed (and hopefully also understood by admin!) if wrong.