Fix: add error log for invalid input visibility args #1569
Conversation
Summary of ChangesHello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a validation check for the visibility argument in the set_repo_visibility method, which is a good improvement. My review includes a suggestion to use predefined constants for visibility values to enhance code maintainability and avoid using magic strings.
| if visibility not in ['private', 'public']: | ||
| raise ValueError(f'Invalid visibility: {visibility}, supported visibilities: `private`, `public`') |
There was a problem hiding this comment.
For better maintainability and to avoid magic strings, it's recommended to use the Visibility constants that are already defined and imported. This ensures that if the visibility values ever change, you only need to update them in one place.
| if visibility not in ['private', 'public']: | |
| raise ValueError(f'Invalid visibility: {visibility}, supported visibilities: `private`, `public`') | |
| if visibility not in [Visibility.PRIVATE, Visibility.PUBLIC]: | |
| raise ValueError(f'Invalid visibility: {visibility}, supported visibilities: `{Visibility.PRIVATE}`, `{Visibility.PUBLIC}`') |
2 participants
No description provided.