Skip to content

Feat: add set_repo_visibility in hub api #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
suluyana merged 3 commits into from
Dec 5, 2025
Merged

Feat: add set_repo_visibility in hub api #1564

suluyana merged 3 commits into from
Dec 5, 2025

Conversation

@wangxingjun778
Copy link
Collaborator

@wangxingjun778 wangxingjun778 commented Dec 4, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 4, 2025

Summary of Changes

Hello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the ModelScope hub API by adding a new function to manage repository visibility. Users can now programmatically set their model and dataset repositories as either public or private, offering greater control over their assets. The changes also include minor type hinting improvements and an update to the return type of an existing model retrieval function, contributing to better API clarity and functionality.

Highlights

  • New Feature: A new method set_repo_visibility has been added to the HubApi class, allowing users to programmatically change the visibility of their model or dataset repositories to either 'private' or 'public'.
  • Type Hinting Enhancement: The Literal type from Python's typing module has been imported and utilized to provide more precise type annotations for parameters like repo_type and visibility in the new set_repo_visibility method.
  • API Response Update: The return type hint for the get_model method has been updated from str to dict, indicating that it now provides a dictionary containing model information.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new function set_repo_visibility to the HubApi class, allowing users to change the visibility of a model or dataset repository. The implementation has a few issues that should be addressed, including potential data corruption due to hardcoded default values, insufficient input validation, lack of error handling for API calls, and use of magic numbers. I've provided specific comments and suggestions to improve the robustness and maintainability of the new function.

@suluyana suluyana merged commit be6874e into modelscope:master Dec 5, 2025
1 of 2 checks passed
suluyana pushed a commit that referenced this pull request Dec 5, 2025
@wangxingjun778
Feat: add set_repo_visibility in hub api (#1564)
4890a8b 
* add set_repo_visibility

* fix cr

* fix lint
suluyana added a commit that referenced this pull request Dec 10, 2025
@suluyana @alcholiclg @wangxingjun778
fix: check tasks in HubApi.set_repo_visibility (#1570)
95aaca3 
* bump version

* Feat/update default revision (#1553)

* Feat: add set_repo_visibility in hub api (#1564)

* add set_repo_visibility

* fix cr

* fix lint

* Add base_model_sub_type for aigc model (#1563)

* Feat: add `DEFAULT_MAX_WORKERS` in snapshot_download func (#1566)

* fix set_repo_visibility (#1568)

Co-authored-by: suluyan <[email protected]>

* fix: check tasks

* for merge master

* fix typo

---------

Co-authored-by: suluyan <[email protected]>
Co-authored-by: Gongsheng Li <[email protected]>
Co-authored-by: Xingjun.Wang <[email protected]>
Co-authored-by: 班扬 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suluyana suluyana suluyana approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangxingjun778 @suluyana