Skip to content

[fix] ans_dfsmn_pipeline.py resample #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangxingjun778 merged 1 commit into from
Sep 28, 2025
Merged

[fix] ans_dfsmn_pipeline.py resample #1510

wangxingjun778 merged 1 commit into from
Sep 28, 2025
+1 −1

Conversation

@weedge
Copy link
Contributor

@weedge weedge commented Sep 22, 2025 

    from modelscope.pipelines import pipeline
    from modelscope.utils.constant import Tasks
    ans = pipeline(Tasks.acoustic_noise_suppression, model="iic/speech_dfsmn_ans_psm_48k_causal")
    result = ans(
        "https://modelscope.oss-cn-beijing.aliyuncs.com/test/audios/speech_with_noise1.wav",# 16k
        output_path="dfsmn_enhancer_output.wav",
    )

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Sep 22, 2025

Summary of Changes

Hello @weedge, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important fix within the acoustic noise suppression pipeline. The change involves making the librosa.resample function call more explicit by naming its sample rate arguments, ensuring the code remains clear and less susceptible to breaking changes in external libraries.

Highlights

  • Code Clarity and Robustness: The librosa.resample function call in ans_dfsmn_pipeline.py has been updated to explicitly use keyword arguments orig_sr and target_sr. This enhances code readability and robustness against potential future changes in librosa's positional argument order.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 22, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the call to librosa.resample in ans_dfsmn_pipeline.py to use keyword arguments. This is an important fix that ensures compatibility with recent versions of the librosa library (>=0.9.0) where orig_sr and target_sr are keyword-only arguments. The change improves code readability and prevents potential runtime errors. The implementation is correct and I have no further feedback.

@wangxingjun778 wangxingjun778 merged commit 7a37e99 into modelscope:master Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxingjun778 wangxingjun778 wangxingjun778 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weedge @wangxingjun778