Fix invalid revision in repo_info #1496
Conversation
alcholiclg
commented
Sep 11, 2025
alcholiclg
commented
- fix error when repo_info is called with a non-existent revision
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @alcholiclg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the robustness of the repo_info utility by ensuring it gracefully handles scenarios where an invalid or non-existent revision is queried. It prevents potential errors by providing a default empty response when no commit data is returned from the API.
Highlights
- Error Handling: Implemented a check in CommitHistoryResponse.from_api_response to handle cases where commits_data is empty, preventing errors when repo_info is called with a non-existent revision.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to fix an error when repo_info is called with a non-existent revision by handling cases where the commit list from the API is empty or null. The added check is a good step, but it's a bit too broad and could lead to incorrect total_count values when the commit list is empty but not null. I've suggested a more precise condition to handle only the null case while preserving the correct total count from the API response.
| if not commits_data: | ||
| return cls( | ||
| commits=[], | ||
| total_count=0, | ||
| ) |
There was a problem hiding this comment.
The condition if not commits_data: is too broad. It evaluates to True for both None and an empty list ([]). When commits_data is an empty list, this implementation incorrectly returns total_count=0, ignoring the TotalCount field that might be present in the API response. This can lead to incorrect information, for example with paginated results where a page can be empty but the total count is non-zero.
To fix this, the check should only handle the None case, allowing empty lists to be processed normally. It should also use the TotalCount from the response data.
| if not commits_data: | |
| return cls( | |
| commits=[], | |
| total_count=0, | |
| ) | |
| if commits_data is None: | |
| return cls( | |
| commits=[], | |
| total_count=data.get('TotalCount', 0), | |
| ) |
Merge remote-tracking branch 'upstream' into fix/wrong_revision
2 participants
