ollama template: qwen3-coder, gemma3n, mistral-small3.2, magistral, devstral #1434
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @suluyana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands the system's compatibility with various large language models by integrating support for several new Ollama model templates. It introduces the necessary configuration entries for qwen3-coder, gemma3n, mistral-small3.2, magistral, and devstral models, along with comprehensive unit tests to ensure their accurate recognition and loading within the framework.
Highlights
- New Ollama Templates Added: I've added
TemplateInfoconfigurations for five new Ollama models:qwen3-coder,gemma3n,mistral-small3.2,magistral, anddevstral. These additions enable the system to correctly identify and load the appropriate templates for these models based on their names. - Expanded Template Recognition Logic: The
modelscope/preprocessors/templates/loader.pyfile has been updated to include new regex patterns andmodelfile_prefixURLs for the newly supported models, ensuring they can be properly mapped to their respective Ollama templates. - Unit Test Coverage for New Templates: Corresponding unit tests have been added to
tests/tools/test_to_ollama.pyto validate that the system correctly recognizes and checks the template types forqwen3-coder,gemma3n,mistral-small3.2,magistral, anddevstralmodels, confirming the new configurations work as expected.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for five new Ollama templates: qwen3-coder, gemma3n, mistral-small3.2, magistral, and devstral. The changes include adding the template definitions in loader.py and corresponding test cases in test_to_ollama.py. The implementation looks correct.
| _test_check_tmpl_type('unsloth/Qwen3-Coder-30B-A3B-Instruct-GGUF', | ||
| 'qwen3-coder') |
There was a problem hiding this comment.
For consistency and better readability, format this function call to align with the style of other calls in this file. Placing arguments on separate lines for long calls improves maintainability.
_test_check_tmpl_type(
'unsloth/Qwen3-Coder-30B-A3B-Instruct-GGUF',
'qwen3-coder')
No description provided.