Skip to content

Update SimpleQA source#948

Merged
Yunnglin merged 1 commit intomainfrom
update/simpleqa
Nov 4, 2025
Merged

Update SimpleQA source#948
Yunnglin merged 1 commit intomainfrom
update/simpleqa

Conversation

@Yunnglin
Copy link
Collaborator

@Yunnglin Yunnglin commented Nov 4, 2025

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 4, 2025

Summary of Changes

Hello @Yunnglin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the reference for the SimpleQA dataset to a new identifier, ensuring consistency across documentation and the dataset's adapter. Additionally, it refines a scoring mechanism within the drivelology benchmark by renaming a key and adjusts the SimpleQA test to process the entire dataset without any imposed limits.

Highlights

  • Dataset ID Update: The SimpleQA dataset ID has been updated from AI-ModelScope/SimpleQA to evalscope/SimpleQA across both English and Chinese documentation, as well as within the simple_qa_adapter.py file.
  • Scoring Metric Renaming: In drivelology_writing_adapter.py, the scoring metric key has been changed from llm_match_score to gpt_score, indicating a potential shift or clarification in the scoring methodology.
  • Test Execution Adjustment: The test_simple_qa function in test_eval.py has been modified to explicitly run without a data limit, ensuring the full dataset is processed during testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the source for the SimpleQA dataset, primarily by changing its ID to evalscope/SimpleQA in both documentation and code. The changes also include a metric name correction in the drivelology benchmark and an update to the simple_qa test to run on the full dataset. While the changes are generally positive, I have raised a concern about removing the test limit, as it may impact CI performance and introduce inconsistency.

@Yunnglin Yunnglin merged commit d5542e0 into main Nov 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Yunnglin