fix (dorp allow few_shot_num=3 in dataset args) 当前存在few_shot_num=3时，会…#940
Conversation
Summary of ChangesHello @yuhuan0311, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在修复 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request addresses an issue in the DROP dataset adapter where the few_shot_num argument was being incorrectly reset to 0 when set to 3. The change removes the else block that was causing this behavior, ensuring that few_shot_num can be set to 3 as intended. This review identifies a critical issue related to the removal of the else block, which could lead to unintended behavior when few_shot_num is explicitly set to 0.
|
LGTM! Thanks for your PR! |
2 participants
fix(drop): allow few_shot_num=3 in dataset args
当前drop精度集的few_shot_num赋值为3时，会进入else逻辑判断，被强制刷新为0