[Feature] Update Bertscore for DrivelologyNarrativeWriting by Yunnglin · Pull Request #935 · modelscope/evalscope

Yunnglin · 2025-10-30T03:23:40Z

Support bert_scorer lazy initialization.

Refer to #909

gemini-code-assist · 2025-10-30T03:23:52Z

Summary of Changes

Hello @Yunnglin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces lazy initialization for the BERTScorer within the Drivelology Narrative Writing benchmark. The primary goal is to optimize resource usage by delaying the loading of the BERTScorer model until it's explicitly required. The changes involve restructuring the BERTScore computation logic into the adapter class and adding a dedicated test to validate the functionality.

Highlights

Lazy Initialization for BERTScorer: The BERTScorer model within the DrivelologyNarrativeWriting benchmark now uses lazy initialization, meaning the model is only loaded when it's first needed, improving resource management.
Refactored BERTScore Computation: The compute_bertscore_one_sample function has been refactored from a standalone utility into a method of the DrivelologyNarrativeWritingAdapter class, enhancing encapsulation.
Thread-Safe Initialization: A new _init_bert_score method, decorated with @thread_safe, ensures that the BERTScorer instance is initialized safely in multi-threaded environments.
New Test Case: A new test test_drivel_writing has been added to tests/benchmark/test_eval.py to cover the Drivelology Narrative Writing benchmark.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively refactors the BERTScore calculation to use lazy initialization, which is a great performance improvement. The implementation is clean and thread-safe. I've added one review comment with a suggestion to further simplify the new compute_bertscore_one_sample method by adjusting its return value to better match its usage, which would improve code clarity and maintainability.