system: df: fix SharedUsage on non-containerd #51631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value was calculated, but due to 0af2962 changing to a non-pointer, the value was not written back to the resulting slice. Before this patch: docker pull nginx:alpine docker pull alpine docker system df -v Images space usage: REPOSITORY TAG IMAGE ID CREATED SIZE SHARED SIZE UNIQUE SIZE CONTAINERS nginx alpine cbad6347cca2 4 weeks ago 53.4MB N/A N/A 0 alpine latest 171e65262c80 7 weeks ago 8.51MB N/A N/A 0 With this patch: docker system df -v Images space usage: REPOSITORY TAG IMAGE ID CREATED SIZE SHARED SIZE UNIQUE SIZE CONTAINERS nginx alpine cbad6347cca2 4 weeks ago 53.4MB 8.512MB 44.91MB 0 alpine latest 171e65262c80 7 weeks ago 8.51MB 8.512MB 0B 0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
impact/changelog
area/images
austinvazquez
approved these changes
Dec 1, 2025
cpuguy83
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker system df -vshows SHARED SIZE and UNIQUE SIZE as "N/A" in 29.1 docker/cli#6686The value was calculated, but due to 0af2962 changing to a non-pointer, the value was not written back to the resulting slice.
Before this patch:
With this patch:
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)