daemon: overlay2: Write layer metadata atomically #46471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the daemon process or the host running it is abruptly terminated, the layer metadata file can become inconsistent on the file system. Specifically, `link` and `lower` files may exist but be empty, leading to overlay mounting errors during layer extraction, such as: "failed to register layer: error creating overlay mount to <path>: too many levels of symbolic links." This commit introduces the use of `AtomicWriteFile` to ensure that the layer metadata files contain correct data when they exist on the file system. Signed-off-by: Mike <[email protected]>
Member
|
/cc @dmcgowan |
dmcgowan
approved these changes
Sep 13, 2023
vvoland
approved these changes
Sep 14, 2023
Member
|
Wanted to have a quick check if Line 13 in 39b2bf5 |
This was referenced Oct 23, 2023
thaJeztah
added
process/cherry-picked
and removed
process/cherry-pick
process/cherry-pick/20.10
process/cherry-pick/23.0
labels
This was referenced Mar 6, 2024
Merged
Merged
JoergZeidler
added a commit
to omnect/meta-omnect
that referenced
this pull request
Jul 26, 2024
…ng power cut (#476) During power cycle tests, we have found multiple sporadically issues in case docker image pull operations and a device power cut. Similar issues are reported here (moby/moby#42964) and a fix was provided here (moby/moby#46471). Signed-off-by: Joerg Zeidler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the band aid to address issue #42964.
When the daemon process or the host running it is abruptly terminated, the layer metadata file can become inconsistent on the file system. Specifically,
linkandlowerfiles may exist but be empty, leading to overlay mounting errors during layer extraction, such as: "failed to register layer: error creating overlay mount to : too many levels of symbolic links."This commit introduces the use of
AtomicWriteFileto ensure that the layer metadata files contain correct data when they exist on the file system.The steps to reproduce the issue are described here #42964.