Skip to content

[23.0 backport] libnetwork: Support IPv6 in arrangeUserFilterRule() #44845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corhere merged 1 commit into from
Jan 19, 2023
Merged

[23.0 backport] libnetwork: Support IPv6 in arrangeUserFilterRule() #44845

corhere merged 1 commit into from
Jan 19, 2023

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 18, 2023 •
edited
Loading

@thaJeztah thaJeztah added this to the 23.0.0 milestone Jan 18, 2023
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 18, 2023

OH! I guess for the 23.0 branch we need to cherry-pick the original PR instead;

#21 0.266 ---> Making bundle: binary (in /tmp/bundles/binary)
#21 0.284 Building static /tmp/bundles/binary-daemon/dockerd (linux/amd64)...
#21 56.70 # github.com/docker/docker/libnetwork
#21 56.70 libnetwork/controller.go:1306:10: undefined: Controller
#21 56.70 libnetwork/firewall_linux.go:33:37: ctrl.ip6tablesEnabled undefined (type *controller has no field or method ip6tablesEnabled)

@neersighted would you have time to look at that, or want me to dig into this?

@neersighted
Copy link
Member

neersighted commented Jan 18, 2023

Yeah, since @corhere's refactoring is not being backported, we need to take the original. I can fix up this PR in a bit.

@neersighted neersighted force-pushed the 23.0_backport_reimplement_44706 branch from 5a27810 to 431f7ba Compare January 18, 2023 19:23
@neersighted neersighted changed the title [23.0 backport] libnetwork: Support IPv6 in arrangeUserFilterRule() (redux) [23.0 backport] libnetwork: Support IPv6 in arrangeUserFilterRule() Jan 18, 2023
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 18, 2023

Thanks! Looks like there's still one failure;

#21 55.13 libnetwork/controller.go:1314:25: c.cfg.DriverCfg undefined (type *config.Config has no field or method DriverCfg)

@neersighted
Copy link
Member

neersighted commented Jan 18, 2023

That's a result of the changes backported in #44728 -- we should probably look at that one first.

@tungmeoo

This comment was marked as off-topic.

Sign in to view
@akerouanton @neersighted
libnetwork: Support IPv6 in arrangeUserFilterRule()
2616ebc 
Fixes moby#44451.

Signed-off-by: Albin Kerouanton <[email protected]>
(cherry picked from commit 2d397be)
Signed-off-by: Bjorn Neergaard <[email protected]>
@neersighted neersighted force-pushed the 23.0_backport_reimplement_44706 branch from 431f7ba to 2616ebc Compare January 19, 2023 15:19
@corhere corhere merged commit cd5e05e into moby:23.0 Jan 19, 2023
@thaJeztah thaJeztah deleted the 23.0_backport_reimplement_44706 branch January 19, 2023 21:24
@GuidoDr GuidoDr mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corhere corhere corhere approved these changes

Assignees

No one assigned

Labels

area/networking Networking impact/changelog kind/bugfix PR's that fix bugs status/2-code-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @neersighted @tungmeoo @corhere @akerouanton