Windows: Move kernel_windows to use golang registry functions #36617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <[email protected]>
thaJeztah
added
platform/windows
status/2-code-review
and removed
status/0-triage
labels
yongtang
added
status/4-merge
rebuild/experimental
and removed
status/2-code-review
labels
Codecov Report
@@ Coverage Diff @@
## master #36617 +/- ##
==========================================
+ Coverage 34.85% 35.08% +0.23%
==========================================
Files 612 612
Lines 45445 45435 -10
==========================================
+ Hits 15838 15940 +102
+ Misses 27537 27387 -150
- Partials 2070 2108 +38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
@thaJeztah @johnstep Follow-up to #36451 (comment). Moves kernel_windows.go to use the golang registry functions.