Add missing lock in ProcessEvent #35516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
Member
|
LGTM. Can we test this? |
Contributor
Author
|
The missing lock, like I said in the description, haven't been able to find a sure test. The race, it'll be tested in docker/cli#696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure [email protected]
- What I did
- How I did it
Updated the code
- How to verify it
Moving the lock a bit earlier fixes #35497 99% of the time. For the missing lock, I haven't been able to get a reliable test
- Description for the changelog
🤷♂️
- A picture of a cute animal (not mandatory but encouraged)
🐱