Enable HotAdd for Windows #35414
Merged
Enable HotAdd for Windows #35414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madhan Raj Mookkandy <[email protected]>
Contributor
Author
|
There is a bug in libnetwork - PR moby/libnetwork#2010 is required to be vendored into docker for hotadd to work properly in Windows |
Contributor
Author
dineshgovindasamy
approved these changes
Nov 6, 2017
dineshgovindasamy
left a comment
dineshgovindasamy
left a comment
There was a problem hiding this comment.
@mavenugo Could you please approve this PR?
Contributor
Author
|
ping @jhowardmsft |
Member
|
Ping @johnstep |
thaJeztah
added
platform/windows
status/2-code-review
area/networking
Member
|
@madhanrm Does this need a system version check (as we need to support RS1+) |
Contributor
Author
|
The platform would throw not supported, if the request is not supported. This PR depends on moby/libnetwork#2010 to be merged first |
johnstep
approved these changes
Feb 1, 2018
Member
johnstep
left a comment
johnstep
left a comment
There was a problem hiding this comment.
LGTM and moby/libnetwork#2010 is merged as of e37374c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Madhan Raj Mookkandy [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)