Fix anchor validation disabled in DEBUG log level#4084
Closed
danielalanbates wants to merge 1 commit intomkdocs:masterfrom
Closed
Fix anchor validation disabled in DEBUG log level#4084danielalanbates wants to merge 1 commit intomkdocs:masterfrom
danielalanbates wants to merge 1 commit intomkdocs:masterfrom
Conversation
Remove the `log.getEffectiveLevel() > logging.DEBUG` guard that prevented `links_to_anchors` from being populated when running with verbose/DEBUG logging. This caused anchor validation to silently stop working in debug mode. Fixes mkdocs#3927 Co-Authored-By: Claude sonnet-4-5 <[email protected]>
Author
|
Thank you for your time reviewing this. We're withdrawing this PR. Apologies for any inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3927.
When running MkDocs with
--verbose(DEBUG log level), anchor validation was silently disabled. The guardif log.getEffectiveLevel() > logging.DEBUGon line 291 ofpages.pypreventedlinks_to_anchorsfrom being populated when the log level was set to DEBUG (value 10), since10 > 10isFalse.This one-line fix removes the conditional so that
links_to_anchorsis always assigned after rendering, regardless of the active log level.Changes
log.getEffectiveLevel() > logging.DEBUGguard inPage.render()that preventedself.links_to_anchorsfrom being set in verbose mode.Test plan
loggingimport is still needed elsewhere in the fileThis PR was created with the assistance of Claude sonnet-4-5 by Anthropic. Happy to make any adjustments! Reviewed and submitted by a human.