fixed extrabacon#109 hardcoded newlines

Almenon · Almenon · commit ed7036cc53da · 2018-02-13T08:49:20.000-08:00
diff --git a/index.js b/index.js
@@ -2,6 +2,7 @@ var EventEmitter = require('events').EventEmitter;
 var path = require('path');
 var util = require('util');
 var spawn = require('child_process').spawn;
+var newline = require('os').EOL;
 
 function toArray(source) {
     if (typeof source === 'undefined' || source === null) {
@@ -179,13 +180,13 @@ PythonShell.prototype.parseError = function (data) {
 
     if (/^Traceback/.test(text)) {
         // traceback data is available
-        var lines = (''+data).trim().split(/\n/g);
+        var lines = (''+data).trim().split(new RegExp(newline, 'g'));
         var exception = lines.pop();
         error = new Error(exception);
         error.traceback = data;
         // extend stack trace
-        error.stack += '\n    ----- Python Traceback -----\n  ';
-        error.stack += lines.slice(1).join('\n  ');
+        error.stack += newline+'    ----- Python Traceback -----'+newline+'  ';
+        error.stack += lines.slice(1).join(newline+'  ');
     } else {
         // otherwise, create a simpler error with stderr contents
         error = new Error(text);
@@ -202,7 +203,7 @@ PythonShell.prototype.parseError = function (data) {
  */
 PythonShell.prototype.send = function (message) {
     var data = this.formatter ? this.formatter(message) : message;
-    if (this.mode !== 'binary') data += '\n';
+    if (this.mode !== 'binary') data += newline;
     this.stdin.write(data);
     return this;
 };
@@ -215,7 +216,7 @@ PythonShell.prototype.send = function (message) {
  */
 PythonShell.prototype.receive = function (data) {
     var self = this;
-    var parts = (''+data).split(/\n/g);
+    var parts = (''+data).split(new RegExp(newline,'g'));
 
     if (parts.length === 1) {
         // an incomplete record, keep buffering
