Skip to content

Commit 16b6b9b

Browse files
gregmalcolmgregmalcolm
committed
Removed some really crappy tests. I was young and foolish when I wrote them... :)
1 parent 11414c5 commit 16b6b9b

File tree

2 files changed

+0
-197
lines changed

2 files changed

+0
-197
lines changed

‎python2/runner/runner_tests/test_sensei.py‎

Lines changed: 0 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -90,39 +90,6 @@ def setUp(self):
9090
self.tests = Mock()
9191
self.tests.countTestCases = Mock()
9292

93-
def test_that_it_delegates_testing_to_test_cases(self):
94-
MockableTestResult.startTest = Mock()
95-
self.sensei.startTest(Mock())
96-
self.assertTrue(MockableTestResult.startTest.called)
97-
98-
def test_that_user_is_notified_if_test_involves_a_different_test_class_to_last_time(self):
99-
MockableTestResult.startTest = Mock()
100-
101-
self.sensei.prevTestClassName == 'AboutLumberjacks'
102-
nextTest = AboutParrots()
103-
104-
self.sensei.startTest(nextTest)
105-
self.assertTrue(self.sensei.stream.writeln.called)
106-
107-
def test_that_user_is_not_notified_about_test_class_repeats(self):
108-
MockableTestResult.startTest = Mock()
109-
110-
self.sensei.prevTestClassName == 'AboutParrots'
111-
nextTest = AboutParrots()
112-
113-
self.sensei.startTest(nextTest)
114-
self.assertTrue(self.sensei.stream.writeln.called)
115-
116-
def test_that_cached_classname_updates_after_the_test(self):
117-
self.assertEqual(None, self.sensei.prevTestClassName)
118-
self.sensei.startTest(Mock())
119-
self.assertNotEqual(None, self.sensei.prevTestClassName)
120-
121-
def test_that_errors_are_diverted_to_the_failures_list(self):
122-
MockableTestResult.addFailure = Mock()
123-
self.sensei.addError(Mock(), Mock())
124-
self.assertTrue(MockableTestResult.addFailure.called)
125-
12693
def test_that_failures_are_handled_in_the_base_class(self):
12794
MockableTestResult.addFailure = Mock()
12895
self.sensei.addFailure(Mock(), Mock())
@@ -134,21 +101,6 @@ def test_that_it_successes_only_count_if_passes_are_currently_allowed(self):
134101
self.sensei.addSuccess(Mock())
135102
self.assertTrue(self.sensei.passesCount.called)
136103

137-
def test_that_if_there_are_failures_and_the_prev_class_is_different_successes_are_not_allowed(self):
138-
self.sensei.failures = [(AboutLumberjacks(), Mock())]
139-
self.sensei.prevTestClassName = "AboutTheMinitry"
140-
self.assertFalse(self.sensei.passesCount())
141-
142-
def test_that_if_there_are_failures_and_the_prev_class_is_the_same_successes_are_allowed(self):
143-
self.sensei.failures = [(AboutLumberjacks(), Mock())]
144-
self.sensei.prevTestClassName = "AboutLumberjacks"
145-
self.assertTrue(self.sensei.passesCount())
146-
147-
def test_that_if_there_are_no_failures_successes_are_allowed(self):
148-
self.sensei.failures = None
149-
self.sensei.prevTestClassName = "AboutLumberjacks"
150-
self.assertTrue(self.sensei.passesCount())
151-
152104
def test_that_it_passes_on_add_successes_message(self):
153105
MockableTestResult.addSuccess = Mock()
154106
self.sensei.addSuccess(Mock())
@@ -160,11 +112,6 @@ def test_that_it_increases_the_passes_on_every_success(self):
160112
self.sensei.addSuccess(Mock())
161113
self.assertEqual(pass_count + 1, self.sensei.pass_count)
162114

163-
def test_that_it_displays_each_success(self):
164-
MockableTestResult.addSuccess = Mock()
165-
self.sensei.addSuccess(Mock())
166-
self.assertTrue(self.sensei.stream.writeln.called)
167-
168115
def test_that_nothing_is_returned_as_a_first_result_if_there_are_no_failures(self):
169116
self.sensei.failures = []
170117
self.assertEqual(None, self.sensei.firstFailure())
@@ -228,41 +175,6 @@ def test_that_it_will_choose_correct_first_result_with_multiline_test_classes(se
228175
]
229176
self.assertEqual("File 'about_giant_feet.py', line 44", self.sensei.firstFailure()[1])
230177

231-
def test_that_end_report_displays_something(self):
232-
self.sensei.learn()
233-
self.assertTrue(self.sensei.stream.writeln.called)
234-
235-
def test_that_end_report_shows_student_progress(self):
236-
self.sensei.errorReport = Mock()
237-
self.sensei.total_lessons = Mock()
238-
self.sensei.total_koans = Mock()
239-
240-
self.sensei.learn()
241-
self.assertTrue(self.sensei.total_lessons.called)
242-
self.assertTrue(self.sensei.total_koans.called)
243-
244-
def test_that_end_report_shows_the_failure_report(self):
245-
self.sensei.errorReport = Mock()
246-
self.sensei.learn()
247-
self.assertTrue(self.sensei.errorReport.called)
248-
249-
def test_that_end_report_should_have_something_zenlike_on_it(self):
250-
self.sensei.say_something_zenlike = Mock()
251-
self.sensei.learn()
252-
self.assertTrue(self.sensei.say_something_zenlike.called)
253-
254-
def test_that_error_report_shows_something_if_there_is_a_failure(self):
255-
self.sensei.firstFailure = Mock()
256-
self.sensei.firstFailure.return_value = (Mock(), "FAILED Parrot is breathing, Line 42")
257-
self.sensei.errorReport()
258-
self.assertTrue(self.sensei.stream.writeln.called)
259-
260-
def test_that_error_report_does_not_show_anything_if_there_is_no_failure(self):
261-
self.sensei.firstFailure = Mock()
262-
self.sensei.firstFailure.return_value = None
263-
self.sensei.errorReport()
264-
self.assertFalse(self.sensei.stream.writeln.called)
265-
266178
def test_that_error_report_features_the_assertion_error(self):
267179
self.sensei.scrapeAssertionError = Mock()
268180
self.sensei.firstFailure = Mock()

‎python3/runner/runner_tests/test_sensei.py‎

Lines changed: 0 additions & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -91,85 +91,18 @@ def setUp(self):
9191
self.tests = Mock()
9292
self.tests.countTestCases = Mock()
9393

94-
def test_that_it_delegates_testing_to_test_cases(self):
95-
MockableTestResult.startTest = Mock()
96-
self.sensei.startTest(Mock())
97-
self.assertTrue(MockableTestResult.startTest.called)
98-
99-
def test_that_user_is_notified_if_test_involves_a_different_test_class_to_last_time(self):
100-
MockableTestResult.startTest = Mock()
101-
102-
self.sensei.prevTestClassName == 'AboutLumberjacks'
103-
nextTest = AboutParrots()
104-
105-
self.sensei.startTest(nextTest)
106-
self.assertTrue(self.sensei.stream.writeln.called)
107-
108-
def test_that_user_is_not_notified_about_test_class_repeats(self):
109-
MockableTestResult.startTest = Mock()
110-
111-
self.sensei.prevTestClassName == 'AboutParrots'
112-
nextTest = AboutParrots()
113-
114-
self.sensei.startTest(nextTest)
115-
self.assertTrue(self.sensei.stream.writeln.called)
116-
117-
def test_that_cached_classname_updates_after_the_test(self):
118-
self.assertEqual(None, self.sensei.prevTestClassName)
119-
self.sensei.startTest(Mock())
120-
self.assertNotEqual(None, self.sensei.prevTestClassName)
121-
122-
def test_that_errors_are_diverted_to_the_failures_list(self):
123-
MockableTestResult.addFailure = Mock()
124-
self.sensei.addError(Mock(), Mock())
125-
self.assertTrue(MockableTestResult.addFailure.called)
126-
127-
def test_that_failures_are_handled_in_the_base_class(self):
128-
MockableTestResult.addFailure = Mock()
129-
self.sensei.addFailure(Mock(), Mock())
130-
self.assertTrue(MockableTestResult.addFailure.called)
131-
13294
def test_that_it_successes_only_count_if_passes_are_currently_allowed(self):
13395
self.sensei.passesCount = Mock()
13496
MockableTestResult.addSuccess = Mock()
13597
self.sensei.addSuccess(Mock())
13698
self.assertTrue(self.sensei.passesCount.called)
13799

138-
def test_that_if_there_are_failures_and_the_prev_class_is_different_successes_are_not_allowed(self):
139-
self.sensei.failures = [(AboutLumberjacks(), Mock())]
140-
self.sensei.prevTestClassName = "AboutTheMinitry"
141-
self.assertFalse(self.sensei.passesCount())
142-
143-
def test_that_if_there_are_failures_and_the_prev_class_is_the_same_successes_are_allowed(self):
144-
self.sensei.failures = [(AboutLumberjacks(), Mock())]
145-
self.sensei.prevTestClassName = "AboutLumberjacks"
146-
self.assertTrue(self.sensei.passesCount())
147-
148-
def test_that_if_there_are_no_failures_successes_are_allowed(self):
149-
self.sensei.failures = None
150-
self.sensei.prevTestClassName = "AboutLumberjacks"
151-
self.assertTrue(self.sensei.passesCount())
152-
153-
def test_that_it_passes_on_add_successes_message(self):
154-
MockableTestResult.addSuccess = Mock()
155-
self.sensei.addSuccess(Mock())
156-
self.assertTrue(MockableTestResult.addSuccess.called)
157-
158100
def test_that_it_increases_the_passes_on_every_success(self):
159101
pass_count = self.sensei.pass_count
160102
MockableTestResult.addSuccess = Mock()
161103
self.sensei.addSuccess(Mock())
162104
self.assertEqual(pass_count + 1, self.sensei.pass_count)
163105

164-
def test_that_it_displays_each_success(self):
165-
MockableTestResult.addSuccess = Mock()
166-
self.sensei.addSuccess(Mock())
167-
self.assertTrue(self.sensei.stream.writeln.called)
168-
169-
def test_that_nothing_is_returned_as_a_first_result_if_there_are_no_failures(self):
170-
self.sensei.failures = []
171-
self.assertEqual(None, self.sensei.firstFailure())
172-
173106
def test_that_nothing_is_returned_as_sorted_result_if_there_are_no_failures(self):
174107
self.sensei.failures = []
175108
self.assertEqual(None, self.sensei.sortFailures("AboutLife"))
@@ -229,48 +162,6 @@ def test_that_it_will_choose_correct_first_result_with_multiline_test_classes(se
229162
]
230163
self.assertEqual("File 'about_giant_feet.py', line 44", self.sensei.firstFailure()[1])
231164

232-
def test_that_end_report_displays_something(self):
233-
self.sensei.learn()
234-
self.assertTrue(self.sensei.stream.writeln.called)
235-
236-
def test_that_end_report_shows_student_progress(self):
237-
self.sensei.errorReport = Mock()
238-
self.sensei.total_lessons = Mock()
239-
self.sensei.total_koans = Mock()
240-
241-
self.sensei.learn()
242-
self.assertTrue(self.sensei.total_lessons.called)
243-
self.assertTrue(self.sensei.total_koans.called)
244-
245-
def test_that_end_report_shows_the_failure_report(self):
246-
self.sensei.errorReport = Mock()
247-
self.sensei.learn()
248-
self.assertTrue(self.sensei.errorReport.called)
249-
250-
def test_that_end_report_should_have_something_zenlike_on_it(self):
251-
self.sensei.say_something_zenlike = Mock()
252-
self.sensei.learn()
253-
self.assertTrue(self.sensei.say_something_zenlike.called)
254-
255-
def test_that_error_report_shows_something_if_there_is_a_failure(self):
256-
self.sensei.firstFailure = Mock()
257-
self.sensei.firstFailure.return_value = (Mock(), "FAILED Parrot is breathing, Line 42")
258-
self.sensei.errorReport()
259-
self.assertTrue(self.sensei.stream.writeln.called)
260-
261-
def test_that_error_report_does_not_show_anything_if_there_is_no_failure(self):
262-
self.sensei.firstFailure = Mock()
263-
self.sensei.firstFailure.return_value = None
264-
self.sensei.errorReport()
265-
self.assertFalse(self.sensei.stream.writeln.called)
266-
267-
def test_that_error_report_features_the_assertion_error(self):
268-
self.sensei.scrapeAssertionError = Mock()
269-
self.sensei.firstFailure = Mock()
270-
self.sensei.firstFailure.return_value = (Mock(), "FAILED")
271-
self.sensei.errorReport()
272-
self.assertTrue(self.sensei.scrapeAssertionError.called)
273-
274165
def test_that_error_report_features_a_stack_dump(self):
275166
self.sensei.scrapeInterestingStackDump = Mock()
276167
self.sensei.firstFailure = Mock()

0 commit comments

Comments
 (0)