Skip to content

Add DiagnosticSource 6.0.0 to MTP telemetry #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 4 commits into from
Oct 1, 2025
Merged

Add DiagnosticSource 6.0.0 to MTP telemetry #6638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5d64c1
Update Microsoft.Testing.Extensions.Telemetry.csproj
Youssef1313 Oct 1, 2025
eff1ee5
Update Directory.Packages.props
Youssef1313 Oct 1, 2025
d8dbc56
Add NoWarn
Youssef1313 Oct 1, 2025
1dc40b9
Update Microsoft.Testing.Extensions.Telemetry.csproj
Youssef1313 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
</ItemGroup>
<ItemGroup Label="Product dependencies">
<!-- If this gets updated, please revise if the explicit dependency on System.Diagnostics.DiagnosticSource is still needed -->
<PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" />

<!-- This comes transitvely via Microsoft.ApplicationInsights, but we want to upgrade it because 5.0.0 is not maintained -->
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />

<PackageVersion Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildVersion)" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis" Version="$(MicrosoftCodeAnalysisVersion)" />
Expand Down
5 changes: 5 additions & 0 deletions ...form/Microsoft.Testing.Extensions.Telemetry/Microsoft.Testing.Extensions.Telemetry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0;$(MicrosoftTestingTargetFrameworks)</TargetFrameworks>
<NoWarn>$(NoWarn);NU1510</NoWarn>
</PropertyGroup>

<!-- NuGet properties -->
Expand Down Expand Up @@ -42,6 +43,10 @@ This package provides telemetry for the platform.]]>

<ItemGroup>
<PackageReference Include="Microsoft.ApplicationInsights" />

<!-- Microsoft.ApplicationInsights already has a dependency on DiagnosticSource. But we want to update the dependency to 6.0.0 instead of 5.0.0 -->
<!-- This is because System.Diagnostics.DiagnosticSource is marked as not maintained -->
<PackageReference Include="System.Diagnostics.DiagnosticSource" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading