Skip to content

Update README.md#321

Closed
ChinmaySheth wants to merge 1 commit into
microsoft:python-previewfrom
ChinmaySheth:patch-1
Closed

Update README.md#321
ChinmaySheth wants to merge 1 commit into
microsoft:python-previewfrom
ChinmaySheth:patch-1

Conversation

@ChinmaySheth

Copy link
Copy Markdown

This is a documentation fix to work with the latest pull request that was merged into the python-preview branch.

@adrianwyatt adrianwyatt requested a review from dluc April 4, 2023 20:55
@adrianwyatt adrianwyatt added the python Pull requests for the Python Semantic Kernel label Apr 4, 2023
@alexchaomander

alexchaomander commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Thank you for finding this! This and other issues are being solved here! #317

Can we consolidate the efforts?

@jjhenkel

jjhenkel commented Apr 4, 2023

Copy link
Copy Markdown

Ah, this is the top-level README (we fixed up the one in the ./python subdir). I'm not quite sure what we should do with the top-level, it'll (eventually) need to get merged w/ the top-level readme in the main branch which could be tricky.

One proposal: take the current top-level README in main, paste it here again, and make minimal edits to add a "python" getting started section? (That matches our ./python/README.md) Or even just a small edit (for now) to link to the appropriate Python readme?

Open to thoughts!

@dluc

dluc commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

@ChinmaySheth we're about to rewrite the main README and to avoid conflicts it's probably better not touching this file for now.

@dluc dluc closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants