This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Deserialize the coverage files directly into the output files#3410
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
- Coverage 34.24% 34.20% -0.05%
==========================================
Files 297 297
Lines 36365 36406 +41
==========================================
- Hits 12453 12452 -1
- Misses 23912 23954 +42
|
individual save function for each formats
tevoinea
reviewed
Aug 15, 2023
tevoinea
reviewed
Aug 15, 2023
tevoinea
reviewed
Aug 15, 2023
tevoinea
approved these changes
Aug 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The Coverage file was loading the output of the coverage in memory before writing it to the output file.
This could cause an increase in memory consumption. This change updates the logic to serialize the output directly in the output file without loading it in the memory.
closes #3420