This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Shrink published Rust debug info#3247
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3247 +/- ##
=======================================
Coverage 29.65% 29.65%
=======================================
Files 332 332
Lines 39290 39290
=======================================
Hits 11651 11651
Misses 27639 27639 |
Porges
changed the title
stishkin
approved these changes
Jun 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed these were getting very big and impacting our CI time due to copying huge artifacts. Presumably this would be slowing down copying in the live environment as well.
Two changes have been made:
debug=1instead ofdebug=true(equivalent todebug=2); this should be sufficient for our needsdebug=1Overall the compressed
release-artifactsreduced from 374 → 297 MB.Build speed improvements (latest build on
mainvs this PR):