Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Add optional condition when updating/re-opening Work Items#3227

Merged
tevoinea merged 7 commits into
microsoft:mainfrom
tevoinea:tevoinea/ConditionallyReopenWIs
Jun 28, 2023
Merged

Add optional condition when updating/re-opening Work Items#3227
tevoinea merged 7 commits into
microsoft:mainfrom
tevoinea:tevoinea/ConditionallyReopenWIs

Conversation

@tevoinea

@tevoinea tevoinea commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

What is this about?

Work Items marked as "Won't Fix" or similar shouldn't be re-opened. Our AdoTemplate didn't have an affordance for that capability.

This PR adds an "Unless" field to on_duplicate. When all of the fields and values in "Unless" match the work item, we will skip updating it.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter

codecov-commenter commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3227 (e46ce90) into main (512bb07) will increase coverage by 0.10%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   29.55%   29.65%   +0.10%     
==========================================
  Files         332      332              
  Lines       39199    39211      +12     
==========================================
+ Hits        11584    11629      +45     
+ Misses      27615    27582      -33
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Model.cs 72.72% <71.42%> (+0.03%) ⬆️
...Service/ApiService/onefuzzlib/notifications/Ado.cs 11.53% <86.66%> (+11.53%) ⬆️

... and 1 file with indirect coverage changes

@tevoinea tevoinea marked this pull request as ready for review June 27, 2023 18:38
Porges
Porges reviewed Jun 27, 2023
View reviewed changes
Comment thread src/ApiService/ApiService/onefuzzlib/notifications/Ado.cs
@tevoinea tevoinea mentioned this pull request Jun 27, 2023
Closed
@tevoinea tevoinea enabled auto-merge (squash) June 28, 2023 13:06
@tevoinea tevoinea merged commit ab2a2b7 into microsoft:main Jun 28, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 13, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.