Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Improve ado validation problem reporting and resiliency#3222

Merged
tevoinea merged 5 commits into
microsoft:mainfrom
tevoinea:tevoinea/ImproveADOValidation
Jun 28, 2023
Merged

Improve ado validation problem reporting and resiliency#3222
tevoinea merged 5 commits into
microsoft:mainfrom
tevoinea:tevoinea/ImproveADOValidation

Conversation

@tevoinea

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

What is this about?

Closes #3135

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter

codecov-commenter commented Jun 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3222 (457668a) into main (85c3e10) will increase coverage by 0.95%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
+ Coverage   28.70%   29.65%   +0.95%     
==========================================
  Files         174      332     +158     
  Lines       21483    39290   +17807     
==========================================
+ Hits         6166    11651    +5485     
- Misses      15317    27639   +12322     
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
...Service/ApiService/onefuzzlib/notifications/Ado.cs 10.02% <0.00%> (ø)

... and 188 files with indirect coverage changes

@tevoinea tevoinea marked this pull request as ready for review June 26, 2023 17:51
@tevoinea tevoinea enabled auto-merge (squash) June 28, 2023 18:52
@tevoinea tevoinea merged commit 9483abc into microsoft:main Jun 28, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve ado validation resiliency and error message

3 participants