This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Add extra_output container, rename extra container#3064
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
- Coverage 29.62% 29.57% -0.05%
==========================================
Files 332 332
Lines 38948 39056 +108
==========================================
+ Hits 11537 11552 +15
- Misses 27411 27504 +93
|
Porges
force-pushed
the
extra-rw-container
branch
from
f6688c5 to
72d76a5
Compare
Porges
force-pushed
the
extra-rw-container
branch
from
72d76a5 to
c04872b
Compare
Porges
force-pushed
the
extra-rw-container
branch
from
c04872b to
ef375c3
Compare
Porges
changed the title
extra_rw containerextra_synced container
Porges
changed the title
extra_synced containerextra_output container
Porges
changed the title
extra_output containerextra_output container, rename extra container
Member
Author
|
Code changes are ready for looking at but this needs its own integration test to be fully complete. |
tevoinea
reviewed
May 26, 2023
tevoinea
reviewed
May 26, 2023
tevoinea
approved these changes
May 26, 2023
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
extra_containertoextra_setup_container.extra_output_container, which pushes its outputs continually.onefuzz-taskfails upon launch, we will log its output for diagnosis (might close Failures happening before the task channel initialization are not reported #3113)Some thoughts for the future:
We might want to redesign the containers so that we have something like the following which is passed to the agent, and the agent doesn't need to know the specifics of the containers supplied:
{ // ... "containers": { "extra_setup_dir": { "mode": "pull", "container_name": "yyy", }, "extra_output_dir": { "mode": "push", "continuous": true, // keep pushing while job is running "container_name": "xxx" } } }At the moment the agent needs to know what each container is for, for each task type. A more generic and flexible method might be simpler overall.